目录
Yixin Wei

Fix GitHub lint: discard Munmap’s error explicitly in data_read (#589)

Summary: Pull Request resolved: https://github.com/facebook/time/pull/589

facebook/time’s GitHub lint job fails on the exported D124865748:

fbclock/data_read.go:122:19: Error return value of unix.Munmap is not checked (errcheck)

The deferred Munmap only drops a read-only mapping after the snapshot is copied, so there’s nothing to do with its error. This discards it explicitly, as shmem_notlinux.go’s deferred Munmaps do.

Internal lint doesn’t report it: arc lint, extra linters included, passes on the unchanged line.

Reviewed By: pmazzini

Differential Revision: D127204480

fbshipit-source-id: f7a1e519e15c5e37192ef24f442d3ce67add57c1

5天前1408次提交
#x27; -fuzz '^FuzzDecodePacket
#x27; -fuzztime 20s ./ptp/protocol/`: 3.4M execs, no failures. `golangci-lint run ./ptp/protocol/...` with the OSS `.golangci.yml`: 0 issues. `buck2 test fbcode//time/ptp/protocol:protocol_test`: 85/85 pass. `arc lint -a`: clean. `arc lint -a -e extra`: no new issues (8 gosec warnings on untouched lines, same count at V1). Reviewed By: vvfedorenko Differential Revision: D126438277 Pulled By: leoleovich fbshipit-source-id: a3075751f255c1a4c24c186585fc0af9c01e0505 " href="/mirrors/time/commits/d9ed9ea949">Parse exactly the PathTrace identities the length field declares (#587)
7天前
  • rtcmrefuse to encode a 1033 frame the package cannot parse (#588)7天前
  • sa53add Phase as default parameter to fetch8天前
  • servoRequire two stable offsets before averaging a frequency2个月前
  • timestampDelete the invalid socket-to-interface bind29天前
  • .gitignoreUpdate packit config to use new SRPM (#496)9个月前
  • .golangci.ymlbump go to 1.25 (#524)5个月前
  • .packit.yamldrop the fbclock-bin spec workaround (#585)27天前
  • CODEOWNERS[time] finish migration facebookincubator to facebook4年前
  • CODE_OF_CONDUCT.md[time] reexport external changes.. (#241)3年前
  • CONTRIBUTING.md[time] Create ntp directory4年前
  • LICENSEAdd LICENSE6年前
  • PULL_REQUEST_TEMPLATE.mdUpdate PULL_REQUEST_TEMPLATE.md5年前
  • README.mdMove ntripper/stats to cmd/ntripper/stats5个月前
  • go.modbump go version (#558)3个月前
  • go.sumBump golang.org/x/crypto from 0.51.0 to 0.52.0 (#549)4个月前
  • Time

    lint test codecov Go Report Card GitHub go.mod Go version GoDoc License

    Contents

    Documentation

    Collection of Meta’s Time Libraries such as NTP and PTP

    cmd

    All executables provided by this repo.

    NTP

    NTP-specific libraries, including protocol implementation.

    PTP

    PTP-specific libraries, including protocol implementation.

    Leaphash

    Utility package for computing the hash value of the official leap-second.list document

    leapsectz

    Utility package for obtaining leap second information from the system timezone database

    PHC

    Library to work with PTP Hardware Clock (PHC).

    Timestamp

    Library to work with NIC hardware/software timestamps.

    oscillatord

    Implementation of monitoring protocol used by Orolia oscillatord.

    Calnex

    Command line tool and library for a Calnex Sentinel device.

    Caliper

    Command line tool for parsing Luciol OTDR trace files when measuring system/cable latencies of Huber-Suhner GNSS-over-fiber systems

    sa53

    Command line tool and library for the Microchip SA53 atomic clock on Celestica time cards.

    fbclock

    Client C library and Go daemon to provide TrueTime API based on PTP time.

    servo

    Pi servo library

    clock

    Wrapper around CLOCK_ADJTIME syscall

    NTRIP

    NTRIP v1 SOURCE client library for pushing RTCM correction data to an NTRIP caster. Supports HTTP CONNECT proxy with TLS client certificate authentication.

    ntripper

    Command line tool that reads RTCM3 and UBX-RXM-RAWX data from an oscillatord Unix socket and pushes RTCM corrections to an NTRIP caster, generating MSM7 messages from raw observations when available.

    RTCM

    Parser and scanner for RTCM 10403.x (RTCM3) binary frames used for GNSS correction data. Includes CRC-24Q validation and stream synchronization.

    License

    time is licensed under Apache 2.0 as found in the LICENSE file.

    邀请码
      Gitlink(确实开源)
    • 加入我们
    • 官网邮箱:gitlink@ccf.org.cn
    • QQ群
    • QQ群
    • 公众号
    • 公众号

    版权所有:中国计算机学会技术支持:开源发展技术委员会
    京ICP备13000930号-9 京公网安备 11010802047560号