目录
main
分支220
标签293
+ 疑修
Web IDE
Peter Dillinger
Fix ldb dump swallowing errors, but ldb scan for compatibility test (#14422)


Summary:
This fixes a longstanding bug in which ldb dump swallows iterator errors. This can affect check_format_compatible.sh test results; if lucky, it will misleadingly look like a data mismatch instead of an outright failure. If unlucky, it could cause a test false negative.


However the compatibility test uses old versions of ldb, so the best way to improve the test (for the foreseeable future) is to replace ldb dump with ldb scan.


Pull Request resolved: https://github.com/facebook/rocksdb/pull/14422


Test Plan: manual


Reviewed By: joshkang97


Differential Revision: D95332577


Pulled By: pdillinger


fbshipit-source-id: bef1b427dd8aaa2cabbd23b7ad9f3cad1f67a349
1个月前13692次提交
gt; make format ``` **new python file** ``` build_tools/format-diff.sh Checking format of uncommitted changes... Checking for copyright headers in new files... Added copyright header to build_tools/test.py Copyright headers were added to new files. Nothing needs to be reformatted! ``` **new header file** ``` build_tools/format-diff.sh Checking format of uncommitted changes... Checking for copyright headers in new files... Added copyright header to db/db_impl/db_impl_jewoongh.h Copyright headers were added to new files. Nothing needs to be reformatted! ``` Reviewed By: hx235 Differential Revision: D87653124 Pulled By: jaykorean fbshipit-source-id: 164322cfcd2c162bb3b41bb8f3bafefa3f20b695 " href="/mirrors/rocksdb/commits/c4bbad4dfe">Update format-diff script to add text to new files (#14143)5个月前
  • build_toolsAdd CLAUDE.md and optimize tooling for claude code (#14293)2个月前
  • cacheRemove deprecated DB::Open raw pointer variants (and more) (#14335)2个月前
  • claude_mdAdd claude md file for deprecated option removal (#14360)2个月前
  • cmakeFix zstd typo in cmake (#12309)2年前
  • coverageinternal_repo_rocksdb1年前
  • dbFix out of disk unit test issue (#14425)1个月前
  • db_stress_toolRelax option sanitization for kv ratio compaction (#14397)1个月前
  • docsBlog post on CPU bug (#14078)2个月前
  • envCheck io_uring probe result in SupportedOps (#14355)2个月前
  • examplesRemove deprecated DB::Open raw pointer variants (and more) (#14335)2个月前
  • fileFix out of disk unit test issue (#14425)1个月前
  • fuzzRemove deprecated DB::Open raw pointer variants (and more) (#14335)2个月前
  • includeExtend UDI trie index with seqno side-table for same-user-key block boundaries (#14412)1个月前
  • javaAdd option to validate sst files in the background on DB open (#14322)2个月前
  • loggingRemove deprecated DB::Open raw pointer variants (and more) (#14335)2个月前
  • memoryRemove deprecated DB::Open raw pointer variants (and more) (#14335)2个月前
  • memtableClarify/rename atomic wrapper stuff + blog post (#14213)3个月前
  • microbenchRemove deprecated DB::Open raw pointer variants (and more) (#14335)2个月前
  • monitoringReformat source files (#14331)2个月前
  • optionsAdd option to validate sst files in the background on DB open (#14322)2个月前
  • pluginAdd initial CMake support to plugin (#9214)4年前
  • portRefactor data block footer to reserve metadata bits for future features (#14332)2个月前
  • tableRefactor MultiScan to use MultiScanIndexIterator (#14401)1个月前
  • test_utilRemove obsolete compression code and some .h->.cc movement (#14325)2个月前
  • third-partyFix tests broken by gtest upgrade (#13661)11个月前
  • toolsFix `ldb dump` swallowing errors, but `ldb scan` for compatibility test (#14422)1个月前
  • trace_replaypropagate request_id from app -> Rocks -> FS (#13616)11个月前
  • unreleased_historyAdd option to validate sst files in the background on DB open (#14322)2个月前
  • utilRefactor MultiScan to use MultiScanIndexIterator (#14401)1个月前
  • utilitiesExtend UDI trie index with seqno side-table for same-user-key block boundaries (#14412)1个月前
  • wikiAdd a new picking algorithm in fifo compaction (#14326)2个月前
  • .clang-formatA script that automatically reformat affected lines12年前
  • .clang-tidy2026 02 21 accelerate ci (#14368)2个月前
  • .gitignoreAdd Meta internal config file to gitignore (#13307)1年前
  • .lgtm.ymlCreate lgtm.yml for LGTM.com C/C++ analysis (#4058)7年前
  • .watchmanconfigAdded .watchmanconfig file to rocksdb repo (#5593)6年前
  • AUTHORSUpdate RocksDB Authors File8年前
  • BUCKRefactor MultiScan to use MultiScanIndexIterator (#14401)1个月前
  • CLAUDE.mdAdd claude md file for deprecated option removal (#14360)2个月前
  • CMakeLists.txtRefactor MultiScan to use MultiScanIndexIterator (#14401)1个月前
  • CODE_OF_CONDUCT.mdAdopt Contributor Covenant6年前
  • CONTRIBUTING.mdAdd Code of Conduct8年前
  • COPYINGAdd GPLv2 as an alternative license.9年前
  • DEFAULT_OPTIONS_HISTORY.mdAdd Options::DisableExtraChecks, clarify force_consistency_checks (#9363)4年前
  • DUMP_FORMAT.mdFirst version of rocksdb_dump and rocksdb_undump.10年前
  • Directory.Build.propsUse ccache to accelerate windows build (#14064)6个月前
  • HISTORY.mdPrepare for 11.1.0 development (#14365)2个月前
  • INSTALL.mdRequire C++20 (#13904)8个月前
  • LANGUAGE-BINDINGS.mdAdd python binding to LANGUAGE-BINDINGS.md (#13391)1年前
  • LICENSE.ApacheChange RocksDB License8年前
  • LICENSE.leveldbAdd back the LevelDB license file8年前
  • MakefileFix out of disk unit test issue (#14425)1个月前
  • PLUGINS.mdAdd encfs plugin link (#12070)2年前
  • README.mdRemove deprecated integration tests from README.md (#11354)3年前
  • USERS.mdAdd Venice as a RocksDB user (#13179)1年前
  • VagrantfileAdding CentOS 7 Vagrantfile & build script8年前
  • WINDOWS_PORT.mdUpdate branch name in WINDOWS_PORT.md (#8745)4年前
  • ccache_msvc_compiler.batUse ccache to accelerate windows build (#14064)6个月前
  • common.mkClean up variables for temporary directory (#9961)4年前
  • crash_test.mkAdd a cleanup target to crash_test.mk (#14286)2个月前
  • folly.mkPrepare for 11.1.0 development (#14365)2个月前
  • issue_template.mdAdd Google Group to Issue Template6年前
  • rocksdb.pc.inbuild: fix pkg-config file generation (#9953)3年前
  • src.mkRefactor MultiScan to use MultiScanIndexIterator (#14401)1个月前
  • thirdparty.incFix build jemalloc api (#5470)6年前
    • README.md

    RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

    CircleCI Status

    RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

    This code is a library that forms the core building block for a fast key-value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it especially suitable for storing multiple terabytes of data in a single database.

    Start with example usage here: https://github.com/facebook/rocksdb/tree/main/examples

    See the github wiki for more explanation.

    The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

    Questions and discussions are welcome on the RocksDB Developers Public Facebook group and email list on Google Groups.

    License

    RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses.

    关于
    c++javastarlark
    README.md
    368.6 MB
    邀请码
      Gitlink（确实开源）
    • 加入我们
    • 官网邮箱：gitlink@ccf.org.cn
      • QQ群
    • QQ群
      • 公众号
    • 公众号

    版权所有：中国计算机学会技术支持：开源发展技术委员会
    京ICP备13000930号-9 京公网安备 11010802032778号